Skip to content

"Token Types" chapter of Idiomatic Rust #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Oct 10, 2025
Merged

"Token Types" chapter of Idiomatic Rust #2921

merged 31 commits into from
Oct 10, 2025

Conversation

@tall-vase
Copy link
Collaborator

Materials on "token types."

The "Branded tokens" section of this one requires a little extra scrutiny. It may be the case it is too complex for this stage, or that the explanation isn't suitable for the audience/instructors. Either way, I'm eager for input.

@google-cla
Copy link

google-cla bot commented Sep 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gribozavr and others added 6 commits September 22, 2025 11:44
@gribozavr
docs: Clarify speaker note style for instructors (google#2917)
36c07e3 
The previous STYLE.md advised against using speaker notes as a 'script'
but didn't provide clear examples of what that meant. This could be
interpreted by LLMs as disallowing any kind of instructor prompt.

This change clarifies the guideline by:

1. Distinguishing between long-form, verbatim 'scripts' (bad) and short,
actionable 'teaching prompts' (good).

2. Providing concrete 'good' and 'bad' examples to make the distinction
unambiguous for future contributors.
Formatting pass
ba2ceda
@tall-vase
Initial skeleton for token types
400c336
@tall-vase
Reframe around mutexguard and a gentle walkthrough of branded tokens
a70aa6b
@tall-vase
Another editing pass, focused on the branded tokens slide
29872e3
Formatting pass
bc6abb0
@gribozavr gribozavr self-requested a review September 28, 2025 19:11
gribozavr
gribozavr requested changes Sep 28, 2025
View reviewed changes
@gribozavr gribozavr added the waiting for author Waiting on the issue author to reply label Sep 28, 2025
gribozavr
gribozavr requested changes Oct 3, 2025
View reviewed changes
@tall-vase tall-vase requested a review from gribozavr October 8, 2025 13:59
@gribozavr gribozavr removed the waiting for author Waiting on the issue author to reply label Oct 8, 2025
@gribozavr gribozavr assigned gribozavr and unassigned tall-vase Oct 8, 2025
gribozavr
gribozavr reviewed Oct 8, 2025
View reviewed changes
@gribozavr gribozavr assigned tall-vase and unassigned gribozavr Oct 8, 2025
@gribozavr gribozavr added the waiting for author Waiting on the issue author to reply label Oct 8, 2025
@tall-vase tall-vase removed the waiting for author Waiting on the issue author to reply label Oct 10, 2025
@tall-vase tall-vase requested a review from gribozavr October 10, 2025 07:52
gribozavr
gribozavr approved these changes Oct 10, 2025
View reviewed changes
@tall-vase tall-vase merged commit 9dcd6f1 into google:main Oct 10, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgeisler mgeisler mgeisler left review comments

@gribozavr gribozavr gribozavr approved these changes

Assignees

@tall-vase tall-vase

Labels

deep_dives/idiomatic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tall-vase @mgeisler @gribozavr